On Mon, May 12, 2014 at 03:28:25PM +0200, Gerd Hoffmann wrote:
Hi,
This patch adds a config option to move PORT_ACPI_PM_BASE, then use the full I/O address space on q35.
Patches have been sent already a few months back, but IIRC we didn't came to a final conclusion. Resending rebased + with minor help text update to re-kick discussion.
Were you looking for this series to be included into the upcoming release?
My concern with the series is patch 1 - I don't think we should be adding a compile time config setting for what I believe should be detected at runtime.
It would seem to me that the QEMU<->firmware interfaces would be simpler if QEMU just passed the desired iobase to the firmware. (I understand the setting may be needed early in the bootstrap process, but a fw_cfg file could be at a static address, which could then be read during bootstrap with only a few instructions.)
However, if passing the iobase from QEMU to firmware isn't an option, then I think SeaBIOS should at least detect at runtime if it is running on a QEMU version that supports a dynamic iobase.
Am I missing something?
-Kevin