On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote:
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
vring_virtqueue should be zeroed otherwise old values will be reused after reboot.
Signed-off-by: Gleb Natapov gleb@redhat.com diff --git a/src/virtio-blk.c b/src/virtio-blk.c index 34d7863..7a25826 100644 --- a/src/virtio-blk.c +++ b/src/virtio-blk.c @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf) goto fail; } memset(vdrive_g, 0, sizeof(*vdrive_g));
- memset(vq, 0, sizeof(*vq)); vdrive_g->drive.type = DTYPE_VIRTIO; vdrive_g->drive.cntl_id = bdf; vdrive_g->vq = vq;
This didn't make it into SeaBIOS v0.6.1. Should we add this to the stable branch as v0.6.1.2? Any other bugfixes that need to go in to the stable branch (maybe Isaku's pci overflow patches)?
Yes. Please add it to stable branch.
-- Gleb.