Re: [SeaBIOS] New build warnings with GCC 5

[Kevin O'Connor]

On Tue, Jun 02, 2015 at 10:50:30PM +0200, Paul Menzel wrote:
> Am Montag, den 01.06.2015, 18:36 -0400 schrieb Kevin O'Connor:
> > On Sat, May 23, 2015 at 03:47:32PM +0200, Paul Menzel wrote:
> > > building SeaBIOS commit 67643955 (make SeaBios compatible with Xen
> > > vTPM.) for coreboot with the attached configuration with GCC 5.1.1, (CPP
> > > 4.9) the following warnings are printed.
> > >     $ gcc-5 --version
> > >     gcc-5 (Debian 5.1.1-7) 5.1.1 20150522
> > >     Copyright (C) 2015 Free Software Foundation, Inc.
> > >     This is free software; see the source for copying conditions.
> > >     There is NO
> > >     warranty; not even for MERCHANTABILITY or FITNESS FOR A
> > >     PARTICULAR PURPOSE.
> > >
> > >     $ CC=gcc-5 make
> > >       Build Kconfig config file
> > >       Compile checking out/src/misc.o
> > >     In file included from src/misc.c:13:0:
> > >     src/string.h:18:13: warning: inline function 'memcpy_far'
> > >     declared but never defined
> > >      inline void memcpy_far(u16 d_seg, void *d_far
> > >                  ^
> >
> > Thanks.  It looks like gcc v5 is picky about using the "inline"
> > keyword in function declarations.  Patch below fixes the warnings for
> > me.
>
> […]
>
> Applying this patch on top of master, I was unable to reproduce the
> warnings with GCC 5.1.
>
> Acked-by: Paul Menzel

Thanks - applied.

-Kevin