On Wed, 2019-06-19 at 12:27 +0100, David Woodhouse wrote:
For CSM, the highest priority is zero. In SeaBIOS that means "don't", and the highest priority is 1.
So we end up with the fun outcome that booting from NVMe worked only when it *wasn't* selected as the primary boot target, because we don't actually run the nvme_controller_setup() thread for an NVMe controller if its boot prio is zero.
Signed-off-by: David Woodhouse dwmw2@infradead.org
Hm, turns out the NVMe hack is something that's only in our tree so for upstream that second paragraph is a lie and can be dropped.
It's still a correct change to reflect the fact that SeaBIOS doesn't use zero for the highest priority, and correctly handle BBS_DO_NOT_BOOT_FROM and BBS_IGNORE_ENTRY values.