Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code

[Kevin O'Connor]

On Wed, Jul 25, 2012 at 02:45:31PM +0200, Idwer Vollering wrote:
> 2012/7/25 Kevin O'Connor :
> > On Wed, Jul 25, 2012 at 01:44:20PM +0200, Idwer Vollering wrote:
> > > Unmodified tree, at 9d6bac1d32b72cdf7c0ad009c1371a2e69084de3
> >
> > At a guess, the iasl warnings are confusing the
> > acpi_extract_preprocess.py script.  What version of iasl do you have?
>
> The distribution version is iasl 20120620-1: ASL Optimizing Compiler
> version 20120620-64 [Jun 24 2012]
> coreboot build: ASL Optimizing Compiler version 20120420-64 [Jul 13 2012]

Does the patch below fix this for you?

-Kevin

diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
index 2060686..f45162c 100644
--- a/src/acpi-dsdt.dsl
+++ b/src/acpi-dsdt.dsl
@@ -556,7 +556,6 @@ DefinitionBlock (
                     PCNT(Local0, 3)
                 }
             }
-            Return(One)
         }

}
@@ -735,7 +734,6 @@ DefinitionBlock (
                 }
                 Increment(Local0)
             }
-            Return(One)
         }
     }

@@ -749,54 +747,40 @@ DefinitionBlock (
         Name(_HID, "ACPI0006")

Method(_L00) {
-            Return(0x01)
         }
         Method(_E01) {
             // PCI hotplug event
-            Return(_SB.PCI0.PCNF())
+            _SB.PCI0.PCNF()
         }
         Method(_E02) {
             // CPU hotplug event
-            Return(_SB.PRSC())
+            _SB.PRSC()
         }
         Method(_L03) {
-            Return(0x01)
         }
         Method(_L04) {
-            Return(0x01)
         }
         Method(_L05) {
-            Return(0x01)
         }
         Method(_L06) {
-            Return(0x01)
         }
         Method(_L07) {
-            Return(0x01)
         }
         Method(_L08) {
-            Return(0x01)
         }
         Method(_L09) {
-            Return(0x01)
         }
         Method(_L0A) {
-            Return(0x01)
         }
         Method(_L0B) {
-            Return(0x01)
         }
         Method(_L0C) {
-            Return(0x01)
         }
         Method(_L0D) {
-            Return(0x01)
         }
         Method(_L0E) {
-            Return(0x01)
         }
         Method(_L0F) {
-            Return(0x01)
         }
     }
 }