[SeaBIOS] Re: [PATCH v2] bootmenu: add support for more than 9 entries

[Kevin O'Connor]

On Thu, Apr 11, 2019 at 10:01:20PM +0200, Gerd Hoffmann wrote:
> 10th and following entries can be selected using letters.

[...]
> --- a/src/boot.c
> +++ b/src/boot.c
> @@ -465,6 +465,14 @@ get_keystroke(int msec)
>
> #define DEFAULT_BOOTMENU_WAIT 2500
>
> +static const char menuchars[] = {
> '1', '2', '3', '4', '5', '6', '7', '8', '9',
> 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i',
> 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r',
> 's', /* skip t (tpm menu) */
> 'u', 'v', 'w', 'x', 'y', 'z'
>
> +};

FYI, one thing that occurred to me is that the get_raw_keystroke()
command actually has the ascii value of the key (in regs->al) and is
currently discarding it.  Might be simpler to return the ascii value
directly instead of having to loop through the scan_to_keycode table.

-Kevin