Re: [SeaBIOS] [PATCH 16/20] acpi: move cpu hotplug to separate file [q35]

[Kevin O'Connor]

On Tue, Nov 27, 2012 at 10:21:07AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
>
> src/acpi-dsdt-cpu-hotplug.dsl |    1 +
>  src/q35-acpi-dsdt.dsl         |   72 +----------------------------------------
>  2 files changed, 2 insertions(+), 71 deletions(-)
>
> diff --git a/src/acpi-dsdt-cpu-hotplug.dsl b/src/acpi-dsdt-cpu-hotplug.dsl
> index 7f3ad3b..ac7987b 100644
> --- a/src/acpi-dsdt-cpu-hotplug.dsl
> +++ b/src/acpi-dsdt-cpu-hotplug.dsl
> @@ -71,6 +71,7 @@
>                  }
>                  Increment(Local0)
>              }
>        Return(One)

These methods really shouldn't return anything - it was an error in
the previous DSDT versions which newer iasl compilers warn about.
Instead of introducing the Return, the q35 dsdt should be updated to
not return a value.

-Kevin