On Mon, Sep 26, 2011 at 07:58:56PM +0900, Kenji Kaneshige wrote:
(2011/09/23 13:31), Kevin O'Connor wrote:
On Thu, Sep 22, 2011 at 09:58:58PM +0900, Kenji Kaneshige wrote:
Add Local APIC NMI Structure to ACPI MADT.
Thanks. Can you give a brief description of what this is needed by?
Also, is this for kvm, qemu, or some other emulator?
This describes LINT pin (LINT0 or LINT1) to which NMI is connected, and this information is needed by OS to initialize local APIC. Current seabios provides this information through MP configuration table but doesn't provide it through ACPI MADT. I found this when I reviewed "inject NMI" feature in qemu/kvm.
By the way, I think usually NMI is connected to all processors' LINT1 as MultiProcessor spec indicates, and my patch assumes this. But, I noticed that seabios's MP configuration table provides only a NMI information connected to BSP. Is there any special reason about this?
I'm afraid I'm not very knowledgable on the intricacies of LINTx setup.
Your patch looks okay to me, but I would like to see an Ack from one of the QEmu or KVM maintainers as well.