Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

[Kevin O'Connor]

On Mon, Apr 14, 2014 at 11:59:13AM +0200, Gerd Hoffmann wrote:
> On Fr, 2014-04-11 at 11:31 -0400, Kevin O'Connor wrote:
> > On Sun, Apr 06, 2014 at 06:59:53PM -0400, Kevin O'Connor wrote:
> > > This patch series refactors the vgabios graphics mode framebuffer
> > > manipulation code.  It then adds in support for manipulating "direct"
> > > framebuffers that modern vga modes use.
> > >
> > > This series (along with the followup patches for coreboot native vga
> > > vgabios) is also available at:
> > >
> > > https://github.com/KevinOConnor/seabios/tree/testing
> >
> > FYI, I have pushed this patch series (as well as the follow up
> > coreboot native vgabios series) to seabios master.
>
> Some configs fail to build, seems to be the logging:
>
> CONFIG_COREBOOT=y
> CONFIG_QEMU_HARDWARE=y
> CONFIG_VGA_COREBOOT=y
> CONFIG_DEBUG_IO=y
>
> out/vgaccode16.o: In function `runningOnQEMU':
> /home/kraxel/projects/seabios/src/fw/paravirt.h:18: undefined reference
> to `PlatformRunningOn'
>
> Flipping CONFIG_DEBUG_IO to 'n' makes it build fine.

Thanks.  Looks like that set of options would have broken the build
even prior to the vga patch series.  I can fix the compilation with
the patch below, but it wont actually permit the vgabios to use the
debug_io support.  (Getting the debug_io support to work with those
options would be a pain - it would require linking in paravirt.c and
making the qemu detection code work in 16bit mode or making the
vgabios init run in 32bit mode.)

-Kevin
> From fe2cbf6d606e138055b00b0aac6162503a5fb38d Mon Sep 17 00:00:00 2001

Message-Id: 
From: Kevin O'Connor 
Date: Mon, 14 Apr 2014 10:46:34 -0400
Subject: [PATCH] vgabios: Define PlatformRunningOn to make compile happy.
To: [e-mail]

With CONFIG_COREBOOT=y, CONFIG_QEMU_HARDWARE=y, CONFIG_VGA_COREBOOT=y,
CONFIG_DEBUG_IO=y the compile would break because this variable was
missing.

Signed-off-by: Kevin O'Connor 
---
 vgasrc/vgainit.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/vgasrc/vgainit.c b/vgasrc/vgainit.c
index 6d9a224..9d6dd1e 100644
--- a/vgasrc/vgainit.c
+++ b/vgasrc/vgainit.c
@@ -32,6 +32,9 @@ struct VideoSavePointer_s video_save_pointer_table VAR16;

struct VideoParam_s video_param_table[29] VAR16;

+// Type of emulator platform - for dprintf with certain compile options.
+int PlatformRunningOn VAR16;
+

/****************************************************************
  * PCI Data