On 01/25/2010 05:45 PM, Anthony Liguori wrote:
On 01/25/2010 09:06 AM, Avi Kivity wrote:
On 01/24/2010 08:18 PM, Kevin O'Connor wrote:
On Sun, Jan 24, 2010 at 12:16:11PM +0200, Avi Kivity wrote:
That's not correct - when running with PCI -vga std _is_ a PCI device (and it has a BAR). What's needed is to make the VBE BIOS aware of it.
According to Sebastian, the latest version of vgabios (v0.6c) does support this. I see that the following was added to vbe.c:
lfb_addr = pci_get_lfb_addr(0x1234); //experimental vendor
if (lfb_addr> 0) {info.PhysBasePtr = ((Bit32u)lfb_addr<< 16);}It's clear we should pull this for qemu.git master. But what about 0.12? I prefer going back to 0xf0* to reduce the risk for further regressions.
This isn't a guest visible change so for 0.12, I would expect that bringing in the vgabios changes would be reasonable. I don't love the idea of carrying a different behaviour in SeaBIOS and VGABIOS for 0.12 than in master.
It's not guest visible unless it causes regressions. Who knows how this change can interact?
I understand the desire to track upstream, but that shouldn't take precedence over being conservative when applying patches. We should do the bare minimum that it takes to fix the bug, without disturbing unrelated functionality.