On Tue, May 30, 2023 at 09:58:23PM -0400, Kevin O'Connor wrote:
On Fri, May 12, 2023 at 02:14:47PM +0100, José MartÃnez via SeaBIOS wrote:
malloc_high() cannot allocate any memory in CSM mode due to an empty ZoneHigh. SeaBIOS cannot find any disk to boot from because device initialization fails.
The bug was introduced in 1.16.1 (commit dc88f9b) when the meaning of BUILD_MAX_HIGHTABLE changed but CSM code was not updated. This patch reverts to the previous behavior by using BUILD_MIN_HIGHTABLE in CSM methods.
Thanks. The change makes sense to me. Gerd, do you have any comments on this change?
Looks good to me.
Possibly we should add support for larger allocations in CSM mode in a followup patch. Not sure this is needed though, when running in CSM mode I'd suspect features needing large allocations will be handled by the EFI firmware instead of seabios ...
take care, Gerd