On Wed, 11 May 2016 10:08:11 -0400 "Kevin O'Connor" kevin@koconnor.net wrote:
On Wed, May 11, 2016 at 11:50:36AM +0200, Igor Mammedov wrote:
On Tue, 10 May 2016 16:43:34 +0200 Igor Mammedov imammedo@redhat.com wrote:
MaxCountCPUs could never be 0 or less CountCPUs anymore, remove code that wouldn't be executed.
Signed-off-by: Igor Mammedov imammedo@redhat.com
src/fw/smp.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/src/fw/smp.c b/src/fw/smp.c index 18a4c77..4d82502 100644 --- a/src/fw/smp.c +++ b/src/fw/smp.c @@ -175,8 +175,6 @@ smp_setup(void)
[...]
handle_x2apic();
- if (!MaxCountCPUs || MaxCountCPUs < CountCPUs)
MaxCountCPUs = CountCPUs;BTW, the "MaxCountCPUs < CountCPUs" check was in there for really old versions of QEMU that didn't populate "etc/max-cpus". Unless you're sure that "etc/max-cpus" predates CMOS_BIOS_SMP_COUNT, I'd be inclined to leave the check in there. (No need to resend the series if not sure).
yep, taking in account that, only '!MaxCountCPUs ||' should be removed as since 3/4 MaxCountCPUs is always >= 1. I can just post only 1 v3 patch as reply to v2_4/4
-Kevin