Re: [SeaBIOS] [PATCH v2 1/3] ich9: add TCO interface emulation

[Paolo Bonzini]

On 31/05/2015 00:04, Paulo Alcantara wrote:
> case TCO_RLD:
>    tr->timeouts_no = 0;
>    if (can_start_tco_timer(tr)) {
>        tr->tco.rld = tr->tco.tmr;
>        tco_timer_reload(tr);
>    } else {
>        tr->tco.rld = val;

Please mask out bits outside TCO_RLD_MASK here, same as you do for
TCO1_STS_MASK and friends.
>    }
>    break;

[...]
>    tr->tco.cnt1 = tr->tco.cnt1 & TCO_LOCK ? val | TCO_LOCK : val;

Since you have to respin, you can do:

tr->tco.cnt1 = val | (tr->tco.cnt1 & TCO_LOCK);

Otherwise looks good to me.

CCing the maintainer.

Paolo