Re: [SeaBIOS] [PATCH 2/2] Add PCI option ROM blacklist in CBFS

[Paul Menzel]

Am Mittwoch, den 11.02.2015, 17:32 -0600 schrieb Timothy Pearson:
> File:
> pci_optrom_blacklist.txt
>
> Syntax:
> <bus>,<device>,<function>
> Numbers or a single wildcard ('*') are allowed
> Each blacklisted device is placed on separate line

. at end of sentences. ;-)
> Examples:
> Blacklist device 01:04.0:
> 1,4,0
> Blacklist all devices on bus 5:
> 5,*,*
>
> TEST: Booted ASUS KFSN4-DRE with iPXE ROMs built in to CBFS;
> with the two add-on network devices blacklisted the add-on
> network ROMs were ignored while the on-board iPXE ROMs executed
> normally.
> Signed-off-by: Timothy Pearson
>
> src/optionroms.c |  112 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++-

Your MUA Thunderbird wrapped the lines. Please use the preformat(?)
option for patches. I think that was the last formal problem you could
hit with contributing patches to a mailing list. And congratulations,
you had to deal with all the problems, there are, and solved them. ;-)
> 1 file changed, 111 insertions(+), 1 deletion(-)
>
> diff --git a/src/optionroms.c b/src/optionroms.c
> index fbcb6ca..44967e7 100644

[…]

Besides that, the patch looks good to me.

Thanks,

Paul