On Mon, Jul 02, 2018 at 10:35:30AM -0400, Kevin O'Connor wrote:
On Mon, Jul 02, 2018 at 09:10:34AM +0200, Gerd Hoffmann wrote:
The prebuild tables are there exactly to sidestep any iasl version dependencies. We had iasl trouble in the past (IIRC that was newer iasl generating aml opcodes not supported by older windows versions), and keeping up the tables which are legacy only and not expected to ever change didn't look like being worth it. So we added tables build with a known-good iasl version to the repo. I think you can find the full story in the commit log.
If you don't want use the prebuilt tables I think the sane options are (a) use a older iasl compiler, or (b) flip ACPI_DSDT to "n" and drop support for qemu 1.3 + older.
I agree with the above. That said, the patch is trivial enough that I don't think there's any harm in committing it.
I confirmed that older versions of iasl were truncating the table names to 8 characters, and thus the patch has no negative impact. So, I went ahead and committed it.
-Kevin
diff --git a/src/fw/ssdt-misc.dsl b/src/fw/ssdt-misc.dsl index acc850e..d1d2c9e 100644 --- a/src/fw/ssdt-misc.dsl +++ b/src/fw/ssdt-misc.dsl @@ -1,6 +1,6 @@ ACPI_EXTRACT_ALL_CODE ssdp_misc_aml
-DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) +DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSU", 0x1) {
/**************************************************************** diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl index cb24c11..518a5eb 100644 --- a/src/fw/ssdt-pcihp.dsl +++ b/src/fw/ssdt-pcihp.dsl @@ -1,6 +1,6 @@ ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml
-DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) +DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPC", 0x1) {
/****************************************************************