On Mon, 2010-05-10 at 23:05 +0200, Sebastian Herbszt wrote:
Kevin O'Connor wrote:
On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote:
Avoid counting the io hole as part of ram, a vm started with 4G should report 4G in smbios, not 4.5G.
Signed-off-by: Alex Williamson alex.williamson@redhat.com
Looks okay to me. If there are no other comments, I'll commit in the next couple of days.
-Kevin
If i don't mistake it seems to address what i have reported back in January in the "wrong memsize in smbios_init()" thread [1], correct?
[1] http://www.seabios.org/pipermail/seabios/2010-January/000146.html
Yes, it should fix that. I started out effectively where you did, changing memsize to RamSize + RamSizeOver4G, but then quickly ran into the problems Gleb pointed out with some tables wanting address ranges and others wanting quantity. With this patch tables 16, 17, 19, and 20 should make sense and match the spec. Thanks,
Alex