Re: [SeaBIOS] [PATCH 2/3] xhci: disable for QEMU_128K

[Michael S. Tsirkin]

On Wed, Sep 25, 2013 at 04:02:18PM +0200, Gerd Hoffmann wrote:
> On Mi, 2013-09-25 at 12:36 +0300, Michael S. Tsirkin wrote:
> > QEMU 1.6 and earlier didn't have XHCI so we
> > can safely disable that for QEMU_128K.
> > Signed-off-by: Michael S. Tsirkin
> >
> > src/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/Kconfig b/src/Kconfig
> > index d6b6608..f753170 100644
> > --- a/src/Kconfig
> > +++ b/src/Kconfig
> > @@ -235,7 +235,7 @@ menu "Hardware support"
> >          help
> >              Support USB EHCI controllers.
> >      config USB_XHCI
> >    depends on USB && QEMU_HARDWARE
> >    depends on USB && QEMU_HARDWARE && !QEMU_128K
> >    bool "USB XHCI controllers"
> >    default y
> >    help
>
> I still think this is a bad idea.

It's a convenience feature. QEMU developer
can just build stuff without worrying that
someone just added a new feature so now bios
size is too large. There will be less churn
in the QEMU config file.
What's the harm?
> In any case you should not add a dependency but flip the default for the
> small rom, using "default n if QEMU_128K"
>
> cheers,
>   Gerd

Interesting. How does this work?