On Sun, Mar 23, 2014 at 12:04:32PM +0200, Michael S. Tsirkin wrote:
On Sat, Mar 22, 2014 at 07:35:53AM +0000, Jeff wrote:
Hello,
Can someone tells me if the compilation went well? I'm worried about:
out/src/fw/ssdt-pcihp.dsl.i 45: Return (PCEJ(_SUN)) Warning 3104 - Reserved method should not return a value ^ (_EJ0)
Yes, it's ok - it's a new warning produced by recent iasl versions in the ssdt. We moved the ACPI to QEMU so the seabios versions isn't actively maintained. But it's easy to fix so maybe the below should be applied. Or maybe it's better not to touch it ...
If it's an obvious bug fix, it's probably better to fix it. Could you send to the mailing list?
-Kevin
Note: lightly tested with a linux guest only.
---> acpi: fix up iasl warning
out/src/fw/ssdt-pcihp.dsl.i 45: Return (PCEJ(_SUN)) Warning 3104 - Reserved method should not return a value ^ (_EJ0)
Signed-off-by: Michael S. Tsirkin mst@redhat.com
diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl index 67e485f..cb24c11 100644 --- a/src/fw/ssdt-pcihp.dsl +++ b/src/fw/ssdt-pcihp.dsl @@ -29,7 +29,7 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) Name(_ADR, 0xAA0000) ACPI_EXTRACT_METHOD_STRING ssdt_pcihp_ej0 Method(_EJ0, 1) {
Return (PCEJ(_SUN))
PCEJ(_SUN) } }