Re: [SeaBIOS] [PATCH 01/20] seabios: make mttr UC area setup dynamic

[Jason Baron]

On Tue, Nov 27, 2012 at 10:20:52AM +0100, Gerd Hoffmann wrote:
> From: Jason Baron
>
> Set up the UC area of mtrr dynamically based on mtrr_base. This allows
> the bios to work for other chipsets that might want to set the mtrr.
> Since BUILD_MAX_HIGHMEM is no longer used we can remove the config parameter.
>
> This change reverses the order of pci_setup() and smm_init() with
> mtrr_setup().
>
> Signed-off-by: Jason Baron

I think this needs to be re-worked given Keven's commit:

commit b1c35f2b28cc0c94ebed8176ff61ac0e0b377798
Author: Kevin O'Connor 
Date:   Mon Nov 26 11:05:32 2012 -0500

pciinit: Align start of PCI memory on i440 chipset.

We can use 'pcimem_start' instead of introducing 'mtrr_base'. Perhaps, we
should also add a check that the value of 'pcimem_start' is one of:

0x80000000
0xc0000000
0xe0000000

Although I think we just need a warning for that case, not a hard error.

Thanks,

-Jason