On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann kraxel@redhat.com wrote:
Too many changes in a single patch. Needs splitting up into one patch per change.
Good idea, thank you. I could try to split the numpad support/console interface into a second patch. Although I provided a coreboot.rom QEMU image with lots of floppies, which could have been used for a review of this patch to see it in action :
Here is a coreboot image for QEMU with these two patches applied and my
collection of wonderful and useful floppies added to popular the entries list: https://github.com/mikebdp2/floparchive/blob/master/coreboot.rom?raw=true Descriptions of the most prominent floppies could be found here: http://dangerousprototypes.com/docs/Lenovo_G505S_hacking#Useful_floppies
Run this coreboot.rom by executing this QEMU command (some floppies are 64bit)
qemu-system-x86_64 -L . -m 768 -localtime -vga vmware -net nic,model=rtl8139 \ -net user -soundhw ac97 -bios ./coreboot.rom -boot menu=on -serial stdio
On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann kraxel@redhat.com wrote:
Fixed in v2 -- back to single key mode, using letter keys for entry #10 and beyond.
I see that you decided to continue it with "abcdef" instead of suggested "qwerty". Interesting, what approach would be more convenient for the end user... Also, what do you think about moving a tpm menu key from "t" letter (which is weirdly situated in the middle of keyboard) to "m" letter, which is at the end of letter rows? also t = trusted - is an adjective, while m = module is a noun, so seems to be more appropriate for the naming.
On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann kraxel@redhat.com wrote:
Even 10 entries not being enough comes up rarely enough. Now you have 24 (visible) entries with standard vga text mode (80x25).
Just 18-19 considering there could be a TPM and still want to show the top instructions.
On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann kraxel@redhat.com wrote:
Well, the syslinux bootloader comes with a memdisk utility, you can boot from floppy images stored on your hard drive that way. I would prefer this over reflashing the BIOS all day long.
There are floppy OS problems which couldn't be reproduced or debugged this way. For example: Visopsys (interesting floppy OS with GUI for disk partitioning) loads fine from a physical media, but currently can't load as a virtual floppy from coreboot/SeaBIOS because of the problems with ramdisk support. And there was a similar problem with another interesting floppy OS - Fiwix - but we successfully debugged and fixed it together with author.
On Thu, Apr 11, 2019 at 11:34 PM Gerd Hoffmann kraxel@redhat.com wrote:
Also, in your patch version it's not possible to access TPM from a numpad because no t or m keys on it - so I had to add '-' character to the menukeys.
That is pointless unless you fix the tpm menu to support the numpad too.
Sadly I don't have any devices with TPM so it is hard for me to debug this part. The best thing I could do is to hack into SeaBIOS tpm code to make it show the tpm menu entries stuff which does not exist, but at the moment I don't even know how it looks like...
Best regards, Mike Banon