On Fri, Jun 18, 2010 at 02:04:52PM +0200, Stefan Reinauer wrote:
On 6/14/10 12:15 PM, Stefan Reinauer wrote:
This version of the bootsplash patch should have all urgent issues resolved.
Any further things to do, or can this be merged?
Sorry - I got pulled away for a couple of days. I think it can be merged (with some changes - see my other mail).
On a separate note, I have been thinking a bit on the compatibility impact of using the boot splash code. Right now, the code returns to a text console just before launching the OS to ensure that legacy code (which may not work correctly in 1024x768 mode) will still work.
However, the boot code isn't necessarily run - a legacy option rom could hook int 0x19. Also, the option roms themselves may try to write to the screen (eg, a scsi boot config menu), and they may get confused by the video mode.
One way to solve this would be to only show the bootsplash during the boot menu (after option roms and before boot). The machines I have show the boot splash only before option roms, but coreboot+seabios boots so fast it would be pointless to show it then. However, even the boot menu is only shown for 2.5 seconds (CONFIG_BOOTMENU_WAIT). Also, switching resolutions before and after the boot menu might be annoying for users.
One possibility would be to try to use the same resolution for the bootsplash as the text console (720x400).
I'm not sure this is even a real problem. Any thoughts?