Re: [SeaBIOS] [PATCH 1/2] Add an IPMI SMBIOS entry

[Kevin O'Connor]

On Tue, Sep 18, 2012 at 03:45:52PM -0500, [e-mail] wrote:
> From: Corey Minyard
>
> An IPMI device is being added to the qemu code, and it has an
> SMBIOS entry to describe the interface characteristics.  So add
> the SMBIOS entry to the BIOS so it can handle this.

[...]
> +struct ipmi_info {
> u8 str_version; /* Version of this structure */
> u8 interface;
> u8 reg_space;
> u8 reg_spacing;
> u8 slave_addr;
> u8 irq;
> u8 version;
> u8 reserved1;
> u64 base_addr;
> u64 end_addr;
>
> +} PACKED;

[...]
> +/* SMBIOS type 38 - IPMI Information */
> +struct smbios_type_38 {
> struct smbios_structure_header header;
> u8 interface_type;
> u8 ipmi_version;
> u8 i2c_slave_addr;
> u8 nv_storage_dev_addr;
> u64 base_addr;
> u8 base_addr_mod_and_irq_info;
> u8 interrupt_number;
>
> +} PACKED;

Hi Corey,

Sorry, but the above is still a problem for me.

In the recent q35 patches there was discussion of providing more of
the acpi tables via qemu (in order to support more hardware
variations).  Perhaps these patches should take a similar approach.

-Kevin