Re: [SeaBIOS] [PATCH] pci: panic when out of bus numbers

[Peter Stuge]

Marcel Apfelbaum wrote:
> > Given the bus number register is 8bit I'm wondering whenever this is a
> > valid hardware configuration in the first place?
>
> For sure no :), however we do have a possible endless loop
> and maybe is cleaner to panic. (no matter who is "responsible")

I would prefer SeaBIOS to discard invalid requests and boot anyway.
> > In case it isn't I think qemu should throw an error instead if you try
> > to create a vm with more than 255 pci busses.
>
> I suppose it could go into QEMU too, I'll give it a try.

Please do, I think the check should be in both places. I think QEMU
should throw an error if the user requests an invalid hardware
configuration.

//Peter