[SeaBIOS] Re: SeaBIOS fails to boot from NVMe controller with lots of namespaces

[Cole Robinson]

On 5/25/21 12:06 PM, Thanos Makatos wrote:
> > -----Original Message-----
> > From: Cole Robinson 
> > Sent: 25 May 2021 17:01
> > To: Gerd Hoffmann 
> > Cc: Thanos Makatos ; [e-mail];
> > John Levon ; Swapnil Ingle
> > ; Liu, Changpeng 
> > Subject: Re: [SeaBIOS] Re: SeaBIOS fails to boot from NVMe controller with
> > lots of namespaces
> >
> > On 5/25/21 9:23 AM, Gerd Hoffmann wrote:
> > > Hi,
> > > > Where can I file this so it doesn't get lost?
> > > > Anyone know a qemu command line workaround?
> > >
> > > Does
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.coreboot.org
> > > _hyperkitty_list_seabios-
> >
> > 40seabios.org_thread_2Q7NPH7TJNHK6JGPHQL7755H
> > >
> >
> > ILO23ISN_&d=DwICAg&c=s883GpUCOChKOHiocYtGcg&r=XTpYsh5Ps2zJvtw6
> > ogtti46a
> > > tk736SI4vgsJiUKIyDE&m=mdjJ1-
> >
> > 1RXDTbTR7f6XC83pvNxgTqd_Yz_1nmiNOsSqk&s=4E
> > > z7Bvnncx71uPWLUTdweByMiN5ypl3-FzhmrDT2ZcY&e=
> > > help?
> >
> > No, tested with qemu.git. Plus the code the patch touches in
> > nvme_controller_enable comes after where the alloc failure happens.
>
> I haven't upstreamed the relevant QEMU patch yet as I'm waiting for the SeaBIOS part to be reviewed first.
>
> The alloc failure can be avoided be setting BUILD_MIN_BIOSTABLE to 32K.

Okay I just tried that, on top of master. It's still not enough for
qemu's 256 namespace default, same reported error. If I override it with
`identify->nn = 128;` in nvme_controller_enable then things start working.

Thanks,
Cole