[SeaBIOS] Re: [PATCH 2/2] resume: move mmconfig reset to pci_resume

[Gerd Hoffmann]

> diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> index b3e359d7..6727546d 100644
> --- a/src/fw/pciinit.c
> +++ b/src/fw/pciinit.c
> @@ -382,6 +382,9 @@ void pci_resume(void)
>     if (!CONFIG_QEMU) {
>         return;
>     }
> make_bios_writable();

Is this really needed?  I'd expect seabios already did that when the
control flow reaches this point.
> extern volatile u32 mmconfig;

Why volatile?
> mmconfig = 0;

Good.
> make_bios_writable();
> // reset mmconfig to make sure that we don't use PCIe to
> // resume PCIe
> dprintf(1, "resetting mmconfig\n");
> extern volatile u32 mmconfig;
> mmconfig = 0;
> dprintf(1, "mmconfig: 0x%x\n", mmconfig);
>
> -//    make_bios_readonly();

Just merge the two patches into one.  Having the first patch add this
just to remove it in the second is pointless and confusing.

take care,
  Gerd