Re: [SeaBIOS] [PATCH 2/5] smm: remove code to handle ACPI disable/enable

[Paolo Bonzini]

Il 15/05/2014 14:56, Don Koch ha scritto:
> On Thu, 15 May 2014 13:22:27 +0200
> Paolo Bonzini  wrote:
> > This is handled already in QEMU, no need to do it in SMM.
>
> Is it needed by coreboot?

This code doesn't run on coreboot.

Paolo
> -d
> > Signed-off-by: Paolo Bonzini
> >
> > src/fw/smm.c | 25 -------------------------
> >  1 file changed, 25 deletions(-)
> >
> > diff --git a/src/fw/smm.c b/src/fw/smm.c
> > index 4176e0c..07f9234 100644
> > --- a/src/fw/smm.c
> > +++ b/src/fw/smm.c
> > @@ -46,34 +46,9 @@ ASM32FLAT(
> >
> > extern u8 smm_code_start, smm_code_end;
> >  ASM32FLAT(
> > /* minimal SMM code to enable or disable ACPI */
> > ".global smm_code_start, smm_code_end\n"
> > "  .code16gcc\n"
> > "smm_code_start:\n"
> > "  movw $" __stringify(PORT_SMI_CMD) ", %dx\n"
> > "  inb %dx, %al\n"
> > "  cmpb $0xf0, %al\n"
> > "  jne 1f\n"
> > /* ACPI disable */
> > "  movw $" __stringify(PORT_ACPI_PM_BASE) " + 0x04, %dx\n" /* PMCNTRL */
> > "  inw %dx, %ax\n"
> > "  andw $~1, %ax\n"
> > "  outw %ax, %dx\n"
> > "  jmp 2f\n"
> > "1:\n"
> > "  cmpb $0xf1, %al\n"
> > "  jne 2f\n"
> > /* ACPI enable */
> > "  movw $" __stringify(PORT_ACPI_PM_BASE) " + 0x04, %dx\n" /* PMCNTRL */
> > "  inw %dx, %ax\n"
> > "  orw $1, %ax\n"
> > "  outw %ax, %dx\n"
> > "2:\n"
> > "  rsm\n"
> > "smm_code_end:\n"
> > "  .code32\n"
> >
> > SeaBIOS mailing list
> > [e-mail]
> > http://www.seabios.org/mailman/listinfo/seabios