On Fri, Jun 05, 2015 at 06:41:30PM +0200, Peter Stuge wrote:
Kevin O'Connor wrote:
If the new "VERSION=" parameter is not provided then the default build version remains unchanged.
I prefer Alex' patch, because it defaults to reproducible but provides more information if the tree has been modified, all automatically.
A user parameter like your VERSION *on top of that* is fine, but why not have reproducible by default like with Alex' patch when that doesn't really lose any information?
I find value in the hostname and date on trouble reports - it helps determine if the binary was built by a distribution and it can help backtrack to the gcc/binutils/etc. versions.
I find value in the timestamp during debug cycles as a means of verifying I'm running the correct code during a test run.
So, I'm against changing the default to lose this information - either in the debault SeaBIOS build or the default coreboot build.
-Kevin