[SeaBIOS] Re: [PATCH v2] bootmenu: add support for more than 9 entries

[Gerd Hoffmann]

> > > +static const char menuchars[] = {
> > > '1', '2', '3', '4', '5', '6', '7', '8', '9',
> > > 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i',
> > > 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r',
> > > 's', /* skip t (tpm menu) */
> > > 'u', 'v', 'w', 'x', 'y', 'z'
> > >
> > > +};
> >
> > FYI, one thing that occurred to me is that the get_raw_keystroke()
> > command actually has the ascii value of the key (in regs->al) and is
> > currently discarding it.  Might be simpler to return the ascii value
> > directly instead of having to loop through the scan_to_keycode table.
>
> Looping through the scan_to_keycode() table has the advantage that the
> modifier state is ignored.  So it doesn't matter whenever you press 'a'
> or 'A' (shift or capslock active), both will work ...

Tried updating get_keystroke() nevertheless, it looks nicer after all,
and can maybe used elsewhere too to make the code more readable.

cheers,
  Gerd