[SeaBIOS] Re: [PATCH] virtio: finalizing features before using device

[Paul Menzel]

Dear Xuan,

Thank you for your patch.

Am 09.11.22 um 14:17 schrieb Xuan Zhuo:

A small nit for the summary/title (subject), maybe use imperative mood 
*finalize*.
> Under the standard of Virtio 1.0, the initialization process of the
> device must first write sub-features back to device before
> using device, such as finding vqs.
>
> There are four places using vp_find_vq().
> virtio-blk.pci:    put the finalizing features code in front of using device
> virtio-blk.mmio:   put the finalizing features code in front of using device
> virtio-scsi.pci:   is ok
> virtio-scsi.mmio:  add set features before vp_find_vq()

Did you hit an error without the patch? If so, could you please document 
how to reproduce the issue?

[…]

Kind regards,

Paul