Re: [SeaBIOS] [PATCH 6/6] acpi: build PCI hotplug devices from a single template

[Paolo Bonzini]

Il 01/08/2012 02:46, Kevin O'Connor ha scritto:
> I agree with this patch series.  A couple of questions - why not
> create the Notify stuff dynamically (as CPU hotplug does) instead of
> moving it back to the dsdt?

For no particular reason, except that I aimed at 100% correspondence
with the existing SSDT; cleanups can be done on top.  If I were to
resubmit the series with a dynamically-created PCNT, I would add that as
a seventh patch.
> If a device doesn't support hotplug, why
> not skip creating the device instead of patching _EJ0?

1) Because I didn't think of it. :)

2) Because I am not sure of the effect of skipping the _SUN method.

3) Because either you complicate the computation of the size of the
SSDT, or you do not save memory at all.

Paolo