Re: [SeaBIOS] [PATCH] scsi: add AMD PCscsi driver

[Kevin O'Connor]

On Thu, Aug 02, 2012 at 06:26:55PM +0200, Paolo Bonzini wrote:
> This is a driver for an AMD PCscsi (am53c974) SCSI card.  It can be
> used together with DOS or old operating systems such as Windows NT 3.1,
> Windows 3.1 or Windows 98.
>
> Cc: Hervé Poussineau 
> Signed-off-by: Paolo Bonzini
>
> Makefile       |    2 +-
>  src/Kconfig    |    6 ++
>  src/block.c    |    1 +
>  src/blockcmd.c |    3 +
>  src/disk.h     |    1 +
>  src/esp-scsi.c |  231 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/post.c     |    2 +
>  7 files changed, 245 insertions(+), 1 deletion(-)
>  create mode 100644 src/esp-scsi.c

[...]
> --- a/src/post.c
> +++ b/src/post.c
> @@ -28,6 +28,7 @@
>  #include "virtio-blk.h" // virtio_blk_setup
>  #include "virtio-scsi.h" // virtio_scsi_setup
>  #include "lsi-scsi.h" // lsi_scsi_setup
> +#include "esp-scsi.h" // esp_scsi_setup

Your patch is missing "esp-scsi.h".

If you respin, please add a "!COREBOOT" clause to the Kconfig and
update the description to say it has only been tested on emulators.
If someone has the hardware and can confirm it works on real machines
then we can take the clause out - but I'm leery of enabling a hardware
driver without having tested it first.

Thanks.
-Kevin