On Wed, May 29, 2013 at 10:33:54AM +0800, Amos Kong wrote:
On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote:
On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote:
-#define FW_PCI_DOMAIN "/pci@i0cf8" +#define FW_PCI_DOMAIN "/*pci*@i0cf8"
The seabios pattern matching code isn't that sophisticated - I think this could end up doing something unexpected. Why does it need to change?
If we start a guest with default machine type (pc-i440fx), the prefix of bootindex string is "/pci@i0cf8", if we start guest with -M q35, the prefix will become "/q35-pcihost@i0cf8".
We only match "/pci@i0cf8" in seabios, it causes boot priority of q35 devices could not be changed.
We could not change TYPE_Q35_HOST_DEVICE to 'pci' in qemu to adapt seabios, so fix the pattern.
It really can't be changed?
I see glob_prefix() is not powerful, "/*pci*@i0cf8" & "/*@i0cf8" all work.
Or change TYPE_Q35_HOST_DEVICE to "pci-q35" in qemu, and use "/pci*@i0cf8" in seabios ?
That would be preferable.
-Kevin