On Mon, Mar 12, 2012 at 02:40:14PM +0000, Julian Pidancet wrote:
On Sat, Mar 10, 2012 at 7:01 PM, Kevin O'Connor kevin@koconnor.net wrote:
On Wed, Mar 07, 2012 at 02:41:05AM +0000, Julian Pidancet wrote:
Implements VBE function 15h defined in the VBE/DDC standard. Contains a preliminary implementation for bochsvga which returns a hardcoded EDID with some generic informations.
It seems Xorg refuses to use resolutions higher than 1024x768 if the ROM doesn't return an EDID with timing informations to support it.
I think this work can be completed to add support for the Geode vga ROM, as an I2C interface is probably available to extract the EDID from a real monitor.
I'm okay with the change, but I don't think it should be enabled in the upcoming SeaBIOS v1.7.0 release. Perhaps add a config setting and disable it by default.
Also, the comment on patch 2 seems to indicate it is untested. I think it should be tested before committing.
How about including only the first of this 2-patch set. It only adds the 15h function stub and is a pretty low-risk change.
What's the gain to having the stub present? It will always just return an error code, right?
-Kevin