On Tue, 2013-02-12 at 21:27 -0500, Kevin O'Connor wrote:
I'm fine with that change, but I'm not sure how to communicate that to the distro maintainers. I wouldn't want them to try and build the next version of xen and find it mysterously failing.
I'm not so worried about that. Xen ships its own seabios-config file and is set up to build SeaBIOS for itself as part of its build process. So distros who patch it to use their own prebuilt SeaBIOS (like Fedora does) should expect to be at least watching for changes to the config file.
However, if the Xen SeaBIOS image also wants some parts of CONFIG_QEMU like the fw_cfg support, then I do start to wonder if it's actually worth making that change anyway. It was a nice cleanup, with a bunch of s/if (CONFIG_QEMU && !runningOnXen())/if (CONFIG_QEMU)/ and s/if (!CONFIG_QEMU || runningOnXen())/if (!CONFIG_QEMU)/
But now we'd have to add *back* some more complex conditions in other places.... but I suppose it would still be a net win. I'll put it together and test it, and we can make a decision. I really do need to get my act together for testing under Xen *anyway* since I should test OVMF+CSM there, so the effort involved in doing so is mostly not wasted.
BTW, I did pull a bunch of other patches from your tree into the seabios repo.
Ta. I don't have a lot left, do I? :)
I've pushed my dregs out....
- e1272ff8 Enable VGA output when settings bochs-specific mode
You're already looking at this one.
- 20bcdbcf Make Xen one of the top-level build target choices
Will test this and post a version for review.
- 4940c334 Clean up Kconfig options for CSM
Merging this would be good.
- d87fd3cc Add UmbStart,UmbEnd fields to EFI_COMPATIBILITY16_TABLE
Still chasing up the spec change...
- 4def181d Reject non-compliant PCI option ROMs with unaligned PCIR structure
We can drop this if you're not keen, but it *is* an option so people could still keep compatibility with broken ROMs, and consistency is good. We'd never have been shipping broken ROMs if we'd done this in the first place...