Re: [SeaBIOS] [PATCH v2 5/6] add support for etc/sercon-iobase cbfs file

[Kevin O'Connor]

On Thu, Sep 14, 2017 at 09:08:21AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
>
> src/optionroms.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/optionroms.c b/src/optionroms.c
> index 21b72a8ba0..432e8cb02a 100644
> --- a/src/optionroms.c
> +++ b/src/optionroms.c
> @@ -438,6 +438,9 @@ vgarom_setup(void)
>      ret = romfile_loadint("etc/sercon-enable", 0);
>      if (ret)
>          iobase = PORT_SERIAL1;
> ret = romfile_loadint("etc/sercon-iobase", 0);
> if (ret)
>    iobase = ret;

Is "etc/sercon-enable" going to be purely local to seabios, or is
there an intent to produce that from qemu?  If it's purely local, why
not change paravirt.c to produce etc/sercon-iobase=PORT_SERIAL1 when
fwcfg nographics mode is found?

What about the name "etc/sercon-port" instead?

-Kevin