On Fri, Jan 20, 2017 at 12:26:25PM -0800, Julian Stecklina wrote:
This patch enables SeaBIOS to boot from NVMe. Finding namespaces and basic I/O works. Testing has been done in qemu and so far it works with Grub, syslinux, and the FreeBSD loader. You need a recent Qemu (>= October 2016), because older versions have buggy NVMe support.
Thanks. I haven't had a chance to do a review, but one thing I noticed:
--- /dev/null +++ b/src/hw/nvme-int.h @@ -0,0 +1,199 @@ +// NVMe datastructures and constants +// +// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
The copyright would need to say the file is licensed under the LGPLv3. Preference would be to use what the other files have:
// This file may be distributed under the terms of the GNU LGPLv3 license.
-Kevin