19 May
2015
19 May
'15
6:12 a.m.
This code would need to be in the seabios coding style.
Could you point to style guide or to tell exact points you dislike? STFW "seabios style guide" returns no relevant results
Instead of passing this variable all the way through these initialization functions, I suspect it would be much easier to just stash the value in a global variable in the assembler and then read it from that global in the coreboot.c code.
Done.
Why detect a multiboot entry in entry_elf - wouldn't it be much simpler to point the multiboot header to a new entry_multiboot assembler function?
Done.
I don't understand this comment - seabios always uses -mregparam=3 and nearly all the assembler entry stubs rely on this.
Removed.