On Wed, 2013-02-13 at 20:02 -0500, Kevin O'Connor wrote:
On Wed, Feb 13, 2013 at 09:50:13AM +0000, David Woodhouse wrote:
- 4940c334 Clean up Kconfig options for CSM
Merging this would be good.
The "BIOS interfaces" menu allows developers to turn off bios features for testing or to shrink the SeaBIOS binary size. I don't see a gain to limiting what devs can turn off. Turning off CONFIG_BOOT could be useful - an embedded device might want support for running legacy option roms under UEFI but know it will never need to boot in legacy mode. CONFIG_OPTIONROMS doesn't do anything under CSM, but maybe it makes sense to add "if (!CONFIG_OPTIONROMS) return" to the top of handle_csm_0005.
I'm dubious about the sanity of those who use UEFI and yet also actually care about the size of their firmware. But yes, that makes a certain amount of sense. I'll look at implementing the CONFIG_BOOT part of it at least, and I might as well do the CONFIG_OPTIONROMS bit as you suggest too.
Granted, CONFIG_OPTIONROMS_DEPLOYED isn't terribly useful - it's probably about time all that code was just removed. (Or at least set to depends on QEMU.)
OK.
- if (rom->pcioffset & 3)
dprintf(1, "WARNING! Found unaligned PCI rom (vd=%04x:%04x)\n", pd->vendor, pd->device);
Yeah, that works.