27 Oct
2012
27 Oct
'12
11:40 p.m.
On Mon, Oct 22, 2012 at 10:12:03AM +0200, Gerd Hoffmann wrote:
Add a piix4 memory setup function to make the control flow more clear.
Set the new mtrr_base variable (added by q35 patch set) to the start of the 32bit pci window to make sure the mtrr entry added covers the I/O window.
Make the 32bit pci window start at 0x80000000, 0xc0000000 or 0xe000000 (depending on the memory installed) so we can cover the whole window with a single mtrr entry.
Patch looks okay to me. However, as noted in the q35 patch series, I'd prefer to see the scan moved out of pci_bios_map_devices() and the global pcimem_start assigned directly instead of via a pointer.
-Kevin