On Fri, Jun 10, 2011 at 6:04 AM, Kevin O'Connor kevin@koconnor.net wrote:
On Wed, Jun 01, 2011 at 03:14:46PM +0800, Chuang, Alex wrote:
On Wed, June 01, 2011 at 06:57AM +0800, Kevin O'Connor wrote:
Not all SATA controllers can be run in this mode. That's why I set 'IDE_TO_AHCI' default to disable. I only confirm it's working with AMD's SATA controller.
Okay. In that case, I think it would be better to detect the vendor/device ids that can be supported instead of adding a new config option.
It's fine to add vendor ids detect code, but I think config 'IDE_TO_AHCI' should be reserved. Because there are three ways to control AHCI controller.
- AHCI option rom.
- ATA emulation mode in ATA.c.
- non-ATA emulation mode in AHCI.c.
Config 'AHCI' can control non-ATA emulation mode enable/disable in AHCI.c and we also need config 'IDE_TO_AHCI' to control ATA emulation mode enable/disable in ATA.c.
Best regards, Alex
Hi Alex,
Sorry for not getting back to you sooner.
I recently purchased an Asrock E350M1/USB3 motherboard and some flash chips. So, I'll give your patch a spin this weekend.
Basically, I'd like to see if there is some way this can be auto-detected at runtime instead of using a compile time setting.
-Kevin
Kevin,
Auto detect would be great. It would also be good if we could incorporate fixes ScottD made for AHCI. The patch may require some tweaking.
Marc