Re: [SeaBIOS] [PATCH v10 3/6] Support for BIOS interrupt handler

[Xu, Quan]

> -----Original Message-----
> From: Stefan Berger [mailto:[e-mail]]
> Sent: Wednesday, April 29, 2015 7:18 PM
> To: Xu, Quan
> Cc: Kevin O'Connor; [e-mail]; [e-mail];
> [e-mail]; Daniel De Graaf; [e-mail]
> Subject: Re: [PATCH v10 3/6] Support for BIOS interrupt handler
>
> On 04/21/2015 11:22 AM, Kevin O'Connor wrote:
> > On Mon, Mar 30, 2015 at 05:09:47AM +0000, Xu, Quan wrote:
> > > >
> >
> > [...]
> > > I will go through all of these seabios patch, and try to make it compatible for
>
> Xen vTPM.
> > >
> >
> > What's the status of this?  Is it safe to push forward parts of
> > Stefan's patches, or does that represent a regression for Xen?
>
> Xu,  any news? I would like to see these patches making it into the repository.
>
> Regards,
>      Stefan

Stefan,
    Sorry to reply so late to you. I try to make it compatible with Xen vTPM by below patch
Against your serious of patch(https://github.com/KevinOConnor/seabios/tree/tcg-testing ). 
Also I have tested this patch, which is working.

### >>> patch
commit 2c556064695b0a979adb4039f13db1b29a19d3cf
Author: Quan Xu 
Date:   Thu Apr 30 19:43:04 2015 -0400

make SeaBios compatible with Xen vTPM.

Signed-off-by: Quan Xu

diff --git a/src/tcgbios.c b/src/tcgbios.c
index c837ab6..4cda800 100644
--- a/src/tcgbios.c
+++ b/src/tcgbios.c
@@ -23,7 +23,7 @@
 #include "std/acpi.h"  // RSDP_SIGNATURE, rsdt_descriptor
 #include "bregs.h" // struct bregs
 #include "sha1.h" // sha1
-
+#include "fw/paravirt.h" // runningOnXen

static const u8 Startup_ST_CLEAR[2] = { 0x00, TPM_ST_CLEAR };
 static const u8 Startup_ST_STATE[2] = { 0x00, TPM_ST_STATE };
@@ -494,6 +494,8 @@ tpm_start(void)
         return 0;

tpm_acpi_init();
+    if (runningOnXen())
+        return 0;

return tpm_startup();
 }

### <<< patch

Thanks 
Quan Xu