On Tue, Jan 08, 2013 at 04:20:26PM -0700, Eric Blake wrote:
On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote:
"query-dimm-info" and "info dimm" will give current state of all dimms in the system e.g.
dimm0: on dimm1: off dimm2: off dimm3: on etc.
Signed-off-by: Vasilis Liaskovitis vasilis.liaskovitis@profitbricks.com
+++ b/qapi-schema.json @@ -2914,6 +2914,32 @@ { 'command': 'query-memory-total', 'returns': 'int' }
## +# @DimmInfo: +# +# Information about status of a memory hotplug command +# +# @dimm: the Dimm associated with the result +# +# @result: the result of the hotplug command
Here you call it 'result',
+# +# Since: 1.4 +# +## +{ 'type': 'DimmInfo',
- 'data': {'dimm': 'str', 'state': 'bool'} }
but here you call it 'state'. Which is it? And does 'true' mean plugged in, or that the last command succeeded (where the last command may have been either a plug or an unplug)? My preference is that 'true' means plugged in, so more documentation would help.
"True" does mean "plugged in" as you suggest, and the name should be "state". I 'll clarify the documentation.
+## +# @query-dimm-info: +# +# Returns total memory in bytes, including hotplugged dimms
Really?
+# +# Returns: int
Copy-and-paste error? This doesn't return an 'int', but an array of 'DimmInfo'.
both copy-paste errors, will fix.
thanks,
- Vasilis