Re: [SeaBIOS] [PATCH v9 3/6] Support for BIOS interrupt handler

[Stefan Berger]

On 03/20/2015 07:47 PM, Kevin O'Connor wrote:
> On Fri, Mar 20, 2015 at 02:00:38PM -0400, Stefan Berger wrote:
> > From: Stefan Berger
> >
> > This patch implements the TCG BIOS interrupt handler 1ah. It is for
> > example used by trusted grub.
>
> [...]
> > --- a/src/clock.c
> > +++ b/src/clock.c
> > @@ -239,6 +239,17 @@ handle_1a07(struct bregs *regs)
> >       set_success(regs);
> >   }
> >
> > +static void
> > +handle_1abb(struct bregs *regs)
> > +{
> > if (!CONFIG_TCGBIOS)
> >    return;
> > dprintf(DEBUG_tcg, "16: Calling tpm_interrupt_handler\n");
> > extern void _cfunc32flat_tpm_interrupt_handler32(void);
> > call32(_cfunc32flat_tpm_interrupt_handler32, (u32)regs, 0);
>
> I think that "(u32)regs" needs to be "(u32)MAKE_FLATPTR(GET_SEG(SS),
> regs)".  How do you test this handler?

One way to test this is using trusted grub, though I must admit that I 
haven't tested it in a while. I'll do that next week.

Stefan
> -Kevin