Re: [SeaBIOS] [PATCH] Makefile: Explicitly pass `no-pic` to compiler

[Michael Tokarev]

25.10.2016 19:14, Kevin O'Connor wrote:
> On Tue, Oct 25, 2016 at 06:08:08PM +0200, Paul Menzel wrote:
>
> Does the patch below work?
> index 1916ecf..3b94ee0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -63,6 +63,7 @@ COMMONCFLAGS := -I$(OUT) -Isrc -Os -MD -g \
>      -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks \
>      -ffunction-sections -fdata-sections -fno-common -fno-merge-constants
>  COMMONCFLAGS += $(call cc-option,$(CC),-nopie,)
> +COMMONCFLAGS += $(call cc-option,$(CC),-fno-pie,)

Hm. Are there really two different options?
Maybe the first is just a spelling mistake?

Thanks,

/mjt