Re: [SeaBIOS] [PATCH] coreboot: Add support for FMAP and multiple CBFS

[Gerd Hoffmann]

Hi,
> if ((fm->ver_major != FMAP_VER_MAJOR) ||
>    (fm->ver_minor != FMAP_VER_MINOR)) {
>    dprintf(1, "FMAP: bad version %d.%d\n", fm->ver_major, fm->ver_minor);
>    return;
> }

What is the policy on major/minor versioning?

If minor version bumps are supposed to be backward compatible we can
make the minor version test a bit less strict.
> -void
> -coreboot_cbfs_init(void)
> +static void
> +coreboot_cbfs_scan(struct cbfs_file *fhdr, u32 romsize, u32 align)

Factoring out the fbfs scan code into the new coreboot_cbfs_scan
function should be a separate patch.

cheers,
  Gerd