Re: [SeaBIOS] [PATCH v3] add acpi pmtimer support

[Gerd Hoffmann]

On 09/06/12 01:28, Kevin O'Connor wrote:
> On Wed, Sep 05, 2012 at 07:28:15AM +0200, Gerd Hoffmann wrote:
> > This patch makes seabios use the acpi pmtimer instead of tsc for
> > timekeeping.  The pmtimer has a fixed frequency and doesn't need
> > calibration, thus it doesn't suffer from calibration errors due to a
> > loaded host machine.
> >
> > [ v3: mask port ioport read ]
>
> [...]
> > +static u64 pmtimer_get(void)
> > +{
> > u16 ioport = GET_GLOBAL(pmtimer_ioport);
> > u32 wraps = GET_LOW(pmtimer_wraps);
> > u32 pmtimer = inl(ioport);
>
> Mask still missing?

Oops.  Change was still uncommitted in my work tree, /me just forgot
'git add' I guess.  New version on the way.

cheers,
  Gerd