Re: [SeaBIOS] [PATCH v3 1/6] pci: add two-pass pci initializationcode

[Scott Duplichan]

Michael S. Tsirkin wrote:

]> +static u32 pci_index_to_size(int index, enum pci_region_type type)
]> +{
]> +    int shift = (type == PCI_REGION_TYPE_IO) ?
]> +        PCI_IO_INDEX_SHIFT : PCI_MEM_INDEX_SHIFT;
]> +
]> +    return 1 << (index + shift);
]> +}
]> +
]
]0x1 would make me more comfortable.
]I am guessing index + shift is almost always < 31,
]but still.

Hello Michael,

I don't understand how 0x1 would differ from 1 above.
Is it a cosmetic preference only?

Thanks,
Scott