On Tue, 2013-03-19 at 19:08 -0400, Kevin O'Connor wrote:
On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote:
As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control register.
Thanks. I'm okay with the change. It would be nice if someone more familiar with the QEMU side could ack this patch.
As a minor nitpick - there is a pci_config_maskw() that would simplify your code.
Ah, that does clean it up a bit. Actually, hold off on this patch. I'm getting VGA routing setup as I expect, but guests are not happy with the other apertures on the bridges and I'm not sure if I'm contributing to that problem yet. Thanks,
Alex