Re: [SeaBIOS] [PATCH v3 2/8] seabios: acpi: add mcfg table.

[Kevin O'Connor]

On Fri, Oct 19, 2012 at 04:40:59PM -0400, Jason Baron wrote:
> From: Isaku Yamahata
>
> add mcfg table.
> mcfg isn't populated at the moment. dev-q35 will use it later.
>
> [[e-mail]: moved header from post.h -> acpi.h]

Thanks Jason.  Sorry for the delay in review.

I find the code flow of this patch to be confusing.  The code jumps
from build_mcfg to mch_mcfg_init and mch_mcfg_find (patch 5) setting
intermidiate variables (acpi_mcfg) which are then acted on by all of
build_mcfg and mch_mcfg_*.  I think it would be simpler if the code
just detected PCI_DEVICE_ID_INTEL_Q35_MCH and called a function which
did all the work necessary to setup the mcfg acpi table for the q35.

-Kevin