Re: [SeaBIOS] [PATCH] KVM vcpu hotplug seabios infrastructure

[Liu, Jinsong]

Isaku Yamahata wrote:
> I'm referring to git://git.linuxtogo.org/home/kevin/seabios.git
> According to http://www.coreboot.org/SeaBIOS,
> it seems that Keven maintains that repo as the seabios upstream.
> Kevin when pushing patches, which repository should we refer?

I pull from git://git.linuxtogo.org/home/kevin/seabios.git, it has changeset 12cbb43b9dc8a16f712188cb308a0eb0321f3e20, thanks!
> Something like the below didn't work?
> (I just wrote it just to show my idea. I didn't any test.)
>
> +src/%.hex: src/acpi-ssdt.dsl src/mk_ssdt.c
>   @echo "Compiling SSDT for general os which support more cpus"
>   $(Q)$(CC) -o mk_$* src/mk_ssdt.c
>   head -n -2 $< > src/$*.dsl.i
>   ./mk_$* >> src/$*.dsl.i
>   $(Q)cpp -P src/$*.dsl.i > src/$*.dsl
>   $(Q)iasl -tc -p $@ src/acpi-ssdt-anycpu.dsl
>   $(Q)sed -i -e 's/AmlCode/$*/g' $@
>   $(Q)rm mk_$* src/$*.dsl.i src/$*.aml src/$*.dsl

If so, current dependency 'src/%.hex: src/%.dsl' will conflict with new dependency 'src/%.hex: src/acpi-ssdt.dsl src/mk_ssdt.c', like when build src/acpi-ssdt.hex?

BTW, in current Makefile, seems the dependency '$(OUT)ccode32flat.o: src/acpi-dsdt.hex' is redundant.
Without it, makefile still build src/acpi-dsdt.hex. I checked the Makefile but didn't find the reason.

Thanks,
Jinsong